Skip to content

Conversation

@gaurav-nelson
Copy link
Collaborator

@gaurav-nelson gaurav-nelson commented Oct 22, 2025

For https://issues.redhat.com/browse/TELCODOCS-953

Added initial documentation for the new Telco Hub pattern. Covers the overview, configuration, deployment, and management of the pattern. The content is based on https://github.com/validatedpatterns-sandbox/telco-hub-pattern/blob/main/docs/getting-started.md

Preview the docs at https://610--patternsdocs-pr.netlify.app/patterns/telco-hub/

@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Oct 22, 2025

🤖 Wed Nov 05 01:54:46 - The preview is ready at:
https://610--patternsdocs-pr.netlify.app

@gaurav-nelson gaurav-nelson force-pushed the CNF-17611-telco-hub-pattern branch from 6719327 to 848f16f Compare October 24, 2025 01:31
@openshift-ci openshift-ci bot added size/XL and removed size/L labels Oct 24, 2025
@gaurav-nelson gaurav-nelson changed the title WIP: Telco Hub pattern Telco Hub pattern docs Oct 24, 2025
Copy link
Contributor

@imiller0 imiller0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice work @gaurav-nelson. Thank you!
I've added comments...

Copy link

@leo8a leo8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @gaurav-nelson for this effort, it is looking good.

I've dropped comments below and suggestions for updating the content. Hope this helps.

@gaurav-nelson gaurav-nelson force-pushed the CNF-17611-telco-hub-pattern branch from 848f16f to 39b4bdd Compare November 4, 2025 02:49
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@leo8a: GitHub didn't allow me to request PR reviews from the following users: gaurav-nelson.

Note that only validatedpatterns members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Ok, thank you.

/cc @gaurav-nelson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@leo8a leo8a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of more nits I've found here and there, thanks @gaurav-nelson!

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@leo8a: changing LGTM is restricted to collaborators

In response to this:

A couple of more nits I've found here and there, thanks @gaurav-nelson!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gaurav-nelson gaurav-nelson force-pushed the CNF-17611-telco-hub-pattern branch from 39b4bdd to dd75414 Compare November 5, 2025 01:42
@gaurav-nelson gaurav-nelson force-pushed the CNF-17611-telco-hub-pattern branch from dd75414 to 286b3db Compare November 5, 2025 01:47
+
[source,terminal]
----
$ oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub
$ oc describe applications.argoproj.io hub-config -n telco-hub-pattern-hub

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

telco-config doesn't exist in current implementation

-> oc describe applications.argoproj.io telco-config -n telco-hub-pattern-hub
Error from server (NotFound): applications.argoproj.io "telco-config" not found

+
[source,terminal]
----
$ o$ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
$ o$ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern
$ oc describe applications.argoproj.io clusters policies -n telco-hub-pattern

@day0hero day0hero self-requested a review November 5, 2025 09:23
Copy link
Contributor

@day0hero day0hero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 5, 2025
@day0hero day0hero merged commit 6589f6e into validatedpatterns:main Nov 5, 2025
2 checks passed
@gaurav-nelson
Copy link
Collaborator Author

Thank you @leo8a Fixing those nits in #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants